Cross binutils #25232
Cross binutils #25232
Conversation
|
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @viric, @dezgeg and @copumpkin to be potential reviewers. |
Ericson2314
force-pushed
the
cross-binutils
branch
from
ca69d5f
to
f3df5b0
Compare
Ericson2314
added
the
6.topic: cross-compilation
|
@shlevy its hanging and won't let me request a review from you, so I'm doing it here. |
|
Two issues are:
|
| @@ -14,7 +14,7 @@ let | |||
| float = "soft"; | |||
| withTLS = true; | |||
| libc = "glibc"; | |||
| platform = lib.systems.platforms.sheevaplug; | |||
| platform = pkgsNoParams.platforms.sheevaplug; | |||
There was a problem hiding this comment.
Didn't you just merge a PR to master that did the opposite change (pkgsNoParame -> lib.systems)?
There was a problem hiding this comment.
Ah all my rebasing runs the risk of stuff like this. Good catch.
|
@Ericson2314 I never bothered to fix the parser for mingw32, and am fairly busy with other stuff at the moment. It should be easy though. |
Ericson2314
force-pushed
the
cross-binutils
branch
3 times, most recently
from
3522058
to
a922461
Compare
|
Fixed up mingw32 so there's no longer any regressions. |
Ericson2314
force-pushed
the
cross-binutils
branch
2 times, most recently
from
3390044
to
ab5f3a8
Compare
|
Ok rebased this on merged (and remerged, welp) other PRs. Also re-ran the hydra job to ensure everything is ship-shape (so far, so good). |
Ericson2314
force-pushed
the
cross-binutils
branch
from
ab5f3a8
to
2496f98
Compare
This is a cross derivation---it's built on one platform to run on another---so let's structure it like all the other cross derivations.
- No more *Cross duplication for binutils on darwin either. `cctools_cross` is merged into plain `cctools`, so `buildPackages` chains alone are used to disambiguate. - Always use a mashup of cctools and actual GNU Binutils as `binutils`. Previously, this was only done in the native case as nobody had bothered to implement the masher in the cross case. Implemented it basically consisted of extending the wrapper to deal with prefixed binaries.
We want platform triple prefixes and suffixes on derivation names to be used consistently. The ideom this commit strives for is - suffix means build != host, i.e. cross *built* packages. This is already done. - prefix means build != target, i.e. cross tools. This matches the tradition of such binaries themselves being prefixed to disambiguate.] Binutils and cctools, as build tools, now use the latter
Previously this was just done on Darwin.
This does a decent job of testing everything in this PR up to here.
Something better should be done longer term to support such version suffixes.
Ericson2314
force-pushed
the
cross-binutils
branch
from
2496f98
to
80ed251
Compare
|
Ok I think the remaining builds are stalled or something, and I didn't operate hydra correctly to restart. This all worked before I rebased, and "by parametricity" the remaining builds should also work fine, and nobody reviewed up or down while I was out of town, so... merging! |
Motivation for this change
There's a lot more consistency now:
And there are tests to insure the darwin-targeting binutils+cctools mashups do build.
The main question is whether we want to so prefix the binutils derivation name, or adopt another convention distinguished from the existing
build != hostsuffixes.Builds on #25227, factored out of #25047
Things done