Pycharm 2017 -> 2017.1.2 #25673
Merged
Pycharm 2017 -> 2017.1.2 #25673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drdaeman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edwtjo, @miltador and @chris-martin to be potential reviewers. |
7 tasks
|
A PR for release-17.03 as well would be great |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
PyCharm was updated with a new release 2017.1.2. The commits here are pretty much minimal - just version and sha256 updates.
There's one thing, though - URL for pycharm-professional 2017.1 currently responds with 403 error for some reason (no issues for pycharm-community, that one works), which currently breaks
release-17.03if someone hasidea.pycharm-professionalin theirconfiguration.nix. So, I'd ask to please backport the changes to 17.03. This could be slightly inconvenient, as the directory was renamed since then (fromideatojetbrains), so unless that change is also merged there probably will be a merge conflict. To save time, you may want to check my branchpycharm-2017.1.2-release-17.03, which does similar changes from currentrelease-17.03branch. Please tell if you'd want me to make a PR for this.Thanks!
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)