Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Merge fsharp and fsharp41 #25355

Closed
wants to merge 1 commit into from
Closed

[WIP] Merge fsharp and fsharp41 #25355

wants to merge 1 commit into from

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Apr 30, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@kuznero, thanks for your PR! By analyzing the history of the files in this pull request, we identified @7c6f434c, @thoughtpolice and @krgn to be potential reviewers.

@kuznero
Copy link
Member Author

kuznero commented Apr 30, 2017

Please mark as WIP

@7c6f434c
Copy link
Member

By the way, you cannot apply labels without write access to the repository, but you can rename your own PRs, so I would recommend to prepend [WIP] to the PR title (not doing it myself to make sure you complain if GitHub has broken it since the last time I have seen this used)

@kuznero
Copy link
Member Author

kuznero commented May 1, 2017

@7c6f434c thanks

@kuznero kuznero changed the title Merge fsharp and fsharp41 [WIP] Merge fsharp and fsharp41 May 1, 2017
@kuznero kuznero closed this Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants