Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facter: 3.6.0 -> 3.6.4 and related deps #25341

Merged
merged 3 commits into from Apr 30, 2017
Merged

facter: 3.6.0 -> 3.6.4 and related deps #25341

merged 3 commits into from Apr 30, 2017

Conversation

womfoo
Copy link
Member

@womfoo womfoo commented Apr 30, 2017

Motivation for this change

bump to latest upstream

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@womfoo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @globin and @obadz to be potential reviewers.

@obadz obadz merged commit f5939cd into NixOS:master Apr 30, 2017
@womfoo
Copy link
Member Author

womfoo commented Apr 30, 2017

@obadz that was fast! thanks!

@womfoo womfoo deleted the bump/facter-3.6.4 branch April 30, 2017 11:49
@obadz
Copy link
Contributor

obadz commented Apr 30, 2017

@womfoo, np!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@womfoo @mention-bot @obadz