RStudio: 0.98.110 -> 1.1.216 #25338
Merged
RStudio: 0.98.110 -> 1.1.216 #25338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes incompatibilities introduced by a new R version in d16c38a It also fixes NixOS#25315 as a result.
|
@changlinli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Hodapp87, @lverns and @ehmry to be potential reviewers. |
|
The Travis CI build is failing for something that looks like it's hitting multiple different PRs. Should I be worried about that? |
|
Well, you are supposed to check if the Travis failure is related to your update (it may give a useful failure log), but the false positive rate on Travis is quite high, that's not your fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes incompatibilities introduced by a new R version in d16c38a
It also fixes #25315 as a result.
Motivation for this change
Upgrade to latest version of RStudio and also fix a broken RStudio build due to an upgrade in R.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)