Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abcde: specify perl runtime dependencies for abcde-musicbrainz-tool #25362

Merged
merged 2 commits into from May 1, 2017
Merged

abcde: specify perl runtime dependencies for abcde-musicbrainz-tool #25362

merged 2 commits into from May 1, 2017

Conversation

laMudri
Copy link
Contributor

@laMudri laMudri commented Apr 30, 2017

Motivation for this change

Previously, if abcde was set up to use MusicBrainz rather than CDDB, abcde would fail because abcde-musicbrainz-tool couldn't find the Perl dependencies.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@laMudri, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mpashton, @nckx and @cpages to be potential reviewers.

@Mic92 Mic92 merged commit 0c0519b into NixOS:master May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laMudri @mention-bot @Mic92