libvirtd: add address_to method #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mechanism generating the extraHosts declaration is calling this method. So without it, the extraHosts stays basic and inter machine communication can not be defined in a sane way. Furthermore without this the libvirtd backend does not behave like manual state.
|
Committed in 78c732c |
|
Sorry for the delay, libvirtd was broken on NixOS 17.03 for a while, so I wasn't able to test until now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mechanism generating the extraHosts declaration is calling this
method. So without it, the extraHosts stays basic and
inter machine communication can't defined in a sane way.
Furthermore without this the libvirtd backend dosnt' behave like
manual is stating.