virtualbox: 5.1.18 -> 5.1.22 #25368
Merged
virtualbox: 5.1.18 -> 5.1.22 #25368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
|
@globin could you have a look at this PR? |
|
Would be a really cool change!. Guest additions are also updated. The guest additions notification also annoys me. This PR would help fix it. |
|
Is there a reason this PR doesn't get any attention? |
|
This actually doesn't build nor do any of the tests succeed (because of the former). |
|
Working on fixing that patch... |
|
Fixed in 63fb845. |
|
Oh, thank you @aszlig, I had only paid attention to the SHA passing |
|
@aszlig thanks for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to latest upstream version.
Unfortunalty it seems it is still not compatible with X.org ABI 1.19.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)