the_platinum_searcher: 2.1.3 -> 2.1.5 #25360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennofs
reviewed
Apr 30, 2017
| # fixes cycle between $out and $bin | ||
| install_name_tool -delete_rpath $out/lib $bin/bin/pt | ||
| ''; | ||
|
|
There was a problem hiding this comment.
I'm not familar with darwin, but this seems fishy? This seems to remove the dependency from $bin to $out. But why would $out depend on $bin ?
There was a problem hiding this comment.
Yeah I'm not entirely sure. As I understand it it comes from this:
$ cat /nix/store/fxx9f3qi089r0zhzrryfik5w95dlhbbn-the_platinum_searcher-2.1.5/nix-support/propagated-native-build-inputs
/nix/store/0xrkg8rz3x7bzf7z0abxncn3hc3ny4wd-the_platinum_searcher-2.1.5-bin
There was a problem hiding this comment.
Alright, I don't understand this fully either. But if it works, I guess it is fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)