Patch/beamconvspeedup #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry need not be done if there is no stereochemistry.
…er, aromatic flags, and whether to check bond stereo all at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squeeze some more speed out of the SMILES reader at the Beam->CDK handoff. This might be a bit of a no-op as testing the AtomRef patching (on going) I lose about a second in the SMILES Parser, so the solution is to squeeze an extra second out of the current implementation... thus balance is restored.
Current
/data/chembl_22.smi 11.063s
/data/chembl_22.smi 10.401s
/data/chembl_22.smi 10.385s
/data/chembl_22.smi 10.385s
/data/chembl_22.smi 10.387s
Patch
/data/chembl_22.smi 10.021s
/data/chembl_22.smi 9.403s
/data/chembl_22.smi 9.391s
/data/chembl_22.smi 9.371s
/data/chembl_22.smi 9.357s
Times will go back to ~10.5 seconds if I get the AtomRef integrated nicely.