Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkvtoolnix: 9.9.0 -> 11.0.0 #25349

Merged
merged 1 commit into from May 2, 2017
Merged

mkvtoolnix: 9.9.0 -> 11.0.0 #25349

merged 1 commit into from May 2, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 30, 2017

Motivation for this change

Update to version 11.0.0.

See:

Add dependency on Qt’s multimedia component, required for compilation of the GUIs since version 11.0.0.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Add dependency on Qt’s multimedia component, required for compilation
of the GUIs since version 11.0.0.
@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rnhmjoj, @dguibert and @vbgl to be potential reviewers.

@joachifm
Copy link
Contributor

joachifm commented May 1, 2017

The news for 11.0 says

There have been several important bug fixes to the HEVC/h.265 and AVC/h.264 parsers. Among the fixed bugs are some that will silently produce invalid files.

As 10.0 is supposed to have been mainly a bugfix release, I wonder if this means e.g., versions on our release branch are affected by the above bugs. If so we might consider backporting this as well.

@joachifm joachifm merged commit cc5f1f5 into NixOS:master May 2, 2017
@romildo romildo deleted the upd.mkvtoolnix branch May 2, 2017 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants