tarsnap service: add 'verbose' config option #25353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@k0001, thanks for your PR! By analyzing the history of the files in this pull request, we identified @thoughtpolice, @joachifm and @abbradar to be potential reviewers. |
|
LGTM. We might even consider enabling it unconditionally. It all goes to the log anyway, so we're not inconveniencing anybody by increasing the verbosity, right? |
|
I wouldn't recommend making this the default, since among other things it
logs the name of every file being logged, which can be a lot.
…On Apr 30, 2017 22:20, "Joachim F." ***@***.***> wrote:
LGTM. We might even consider enabling it unconditionally. It all goes to
the log anyway, so we're not inconveniencing anybody by increasing the
verbosity, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25353 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAM5rTLNseD4ga8rtqME8OBIXU9ADs3ks5r1O0igaJpZM4NMmjM>
.
|
|
Fair point :) |
domenkozar
approved these changes
May 1, 2017
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
tarsnap's logging output is very quiet, making it hard to tell whether uploads are effectively happening or not. Enabling this newverboseoption makes logging more informative.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)