openshift: 1.3.2 -> 1.5.0 #25369
openshift: 1.3.2 -> 1.5.0 #25369
Conversation
|
@bachp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @offlinehacker to be a potential reviewer. |
| }; | ||
|
|
||
| buildInputs = [ go which ]; | ||
| buildInputs = [ go which removeReferencesTo makeWrapper ]; |
There was a problem hiding this comment.
Was buildGoPackage an option here? This will remove the go dependency automatically.
There was a problem hiding this comment.
I haven't tried with 1.5.0 but as far as I remember for 1.3.x there was a lot going on in the makefiles.
There was a problem hiding this comment.
this should not be an issue if buildPhase is overriden.
There was a problem hiding this comment.
@Mic92 I tried replacing stdenv.mkDerivation with buildGoPackage and adding goPackagePath = "golang.org/x/tools"; but I get the following error when trying to build:
...
./hack/verify-open-ports.sh: interpreter directive changed from "/bin/bash" to "/nix/store/53h800j8kgpj0a349f7wxa5hgkj1vby2-bash-4.4-p12/bin/bash"
./hack/verify-upstream-commits.sh: interpreter directive changed from "/bin/bash" to "/nix/store/53h800j8kgpj0a349f7wxa5hgkj1vby2-bash-4.4-p12/bin/bash"
configuring
grep: Invalid range end
building
make: *** No rule to make target 'build'. Stop.
builder for ‘/nix/store/pf9pqx8a8hh1b2l6nsmsv3apwk1478z5-openshift-origin-1.5.0.drv’ failed with exit code 2
There was a problem hiding this comment.
fixed. to goPackagePath was not correct anyway.
|
Looks like the package is too big for nixos: https://hydra.nixos.org/build/52313947 |
|
Is the build computation-intensive? Because if it is IO-bound, I would advise |
|
On my laptop: the whole build probably takes probably twice the time (fixup takes a while). so it is a mix of computation and i/o |
|
7 minutes for a gigabyte of result? Not literally IO bound, but I would just set empty |
|
Go seems to be pretty efficient when it comes messing with your ssd space. |
|
I think until now most people only use the Me too I also only checked if the binaries can be executed but never actually setup an OpenShift cluster on NixOS. But I don't know how this could be split up to be smaller. |
|
Does somebody know if it is possible to split the binaries into a client and a server part so they can be installed separatly? |
Motivation for this change
Update to latest openshift version and reduce closure size by using removeReferencesTo go.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)