desktop-managers: Use a black BG as fallback #25101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a solid black background when no background image (via ~/.background-image) is provided. In my case this fixes the really strange behaviour when i3 without a desktop manager starts with the SDDM login screen as background image.
primeos
force-pushed
the
desktop-manager-background-fix
branch
from
bd24fe4
to
8528136
Compare
|
also, there is no way to remove the feh dependency but the 'none' manager is always on, and doesn't support that, making the auto-detection always force feh in |
|
@cleverca22 Why shouldn't we be able to remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a solid black background when no background image (via
~/.background-image) is provided. In my case this fixes the really
strange behaviour when i3 without a desktop-manager starts with the SDDM
login screen as background image.
Motivation for this change
Minimal windows managers like
i3won't touch the root window. Using a display manager this seems to cause problems as they alter the root window (at least SDDM does). The result is something like this (note the i3 status-bar at the bottom):Using this patch i3 will "launch" with a (solid) black background when
~/.background-imageisn't present. I actually wonder if we should drop the~/.background-imagesupport since it requires an additional program (feh) and isn't documented in the NixOS manual. But since most users running a minimal WM like i3 will probably usefehanyway it shouldn't really matter.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)