Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: 0.14.6 -> 20170429 #25109

Merged
merged 1 commit into from May 1, 2017
Merged

planner: 0.14.6 -> 20170429 #25109

merged 1 commit into from May 1, 2017

Conversation

amiloradovsky
Copy link

@amiloradovsky amiloradovsky commented Apr 22, 2017

Motivation for this change

Numerous minor fixes since the release.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@amiloradovsky, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rasendubi and @aske to be potential reviewers.

@bjornfor
Copy link
Contributor

Have you suggested to upstream developers to make a release? I find it very wrong when downstreams like Nixpkgs have to use unreleased software. Making a release can be as simple as "git tag && git push" (although many have projects have some more steps). Unless planner is dead upstream, they should make a release!

@amiloradovsky
Copy link
Author

amiloradovsky commented Apr 22, 2017

@bjornfor No, but I was told that "No release planned in the foreseeable future so it may take a while to reach distributions, but at least it’s upstreamed now." -- So I doubt I should suggest it.

@bjornfor
Copy link
Contributor

@amiloradovsky: I don't understand that quote at all. (If they don't make releases, the releases will never reach distributions. What is upstreamed?)

@bjornfor
Copy link
Contributor

@amiloradovsky: Ok, I see now. So you first proposed some patches to planner in Nixpkgs, to fix some bugs. It was suggested instead to apply those patches upstream. You proposed the patches upstream and they integrated them.

Now upstream has 5+ years of features and bug fixes since the latest release, but still have no plans of a release? That's crazy. You should definitely suggest they make a release :-)

@bjornfor
Copy link
Contributor

https://mail.gnome.org/archives/planner-dev-list/2017-April/thread.htm

"The requested URL /archives/planner-dev-list/2017-April/thread.htm was not found on this server."

@amiloradovsky
Copy link
Author

amiloradovsky commented Apr 22, 2017

@bjornfor Ah, it must be html. I probably accidentally deleted the last character.
The entire archive is at https://mail.gnome.org/archives/planner-dev-list/

@amiloradovsky amiloradovsky changed the title planner: 0.14.6 -> 20170422 planner: 0.14.6 -> 20170425 Apr 25, 2017
@amiloradovsky
Copy link
Author

The last patch has just been merged, fixed the revision.
Referencing a release would be fine too, contacted about it here:

Waiting...

Many improvements were performed during the last 5+ years,
since the release: mostly minor fixes but *a lot* of them!

Plus, corrected and expanded the meta a little bit.
@amiloradovsky amiloradovsky changed the title planner: 0.14.6 -> 20170425 planner: 0.14.6 -> 20170429 Apr 29, 2017
@amiloradovsky
Copy link
Author

Hash check failed due to a redirect, fixed.

@7c6f434c 7c6f434c merged commit c9a378a into NixOS:master May 1, 2017
@amiloradovsky amiloradovsky deleted the planner branch May 1, 2017 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants