Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby 2.4] Implemented Integer#ceil, #floor, and #truncate #4571

Closed
wants to merge 6 commits into from
Closed

[ruby 2.4] Implemented Integer#ceil, #floor, and #truncate #4571

wants to merge 6 commits into from

Conversation

whwilder
Copy link
Contributor

@whwilder whwilder commented Apr 21, 2017

Feature #12245 ( ref #4293 )
There was already an implementation of Integer#round. I noticed it had an implementation in Integer that covered both Fixnum and Bignum. Would this be a preferable way of doing things, or is my current method of splitting the implementation between Fixnum and Bignum acceptable?

Edit: Hmm, didn't realize it would include all of my previous commits. I'll close this PR and see if I can fix this.

herwinw and others added 6 commits December 9, 2016 21:19
It passes all the following tests of TestInteger of MRI:

* test_digits
* test_digits_for_negative_numbers
* test_digits_for_invalid_base_numbers
* test_digits_for_non_integral_base_numbers
* test_digits_for_non_numeric_base_argument
@whwilder whwilder closed this Apr 23, 2017
@enebo enebo added this to the Invalid or Duplicate milestone May 11, 2017
@perlun
Copy link
Contributor

perlun commented May 17, 2017

@whwilder did you manage to recreate this including only the relevant parts?

@whwilder
Copy link
Contributor Author

I have. I just tested opening a PR and it looks like everything is in order. I'll go ahead with the new PR unless there's some way to fix this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants