Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curlcpp: 20160901 -> 1.0 #25104

Merged
merged 1 commit into from Apr 22, 2017
Merged

curlcpp: 20160901 -> 1.0 #25104

merged 1 commit into from Apr 22, 2017

Conversation

rszibele
Copy link
Contributor

Motivation for this change

Version bump and updated my maintainer info.

For changes in curlcpp see JosephP91/curlcpp@98286da...f3c5499 .

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@rszibele, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rvl, @zimbatm and @zraexy to be potential reviewers.

@rvl
Copy link
Contributor

rvl commented Apr 22, 2017

Seems find considering there are no nixpkgs which depend on this lib.

Would be nice if this project had releases. Just now there is a new commit on JosephP91/curlcpp#bf0b97d48c4b17e5dc96ddfa0eabd4c2c9a74b21.

@rszibele rszibele mentioned this pull request Apr 22, 2017
Closed
@rszibele
Copy link
Contributor Author

rszibele commented Apr 22, 2017 •
edited

@rlv I've opened an issue over at curlcpp regarding releases. I'll make another version bump when releases get implemented.

joachifm
joachifm reviewed Apr 22, 2017
View reviewed changes
pkgs/development/libraries/curlcpp/default.nix Outdated

src = fetchFromGitHub {
owner = "JosephP91";
repo = "curlcpp";
rev = "f3c5499b312ba649b87f205e8c1f771958227a05";
sha256 = "0mwj5ghr04s6n3dkm50gp1aj0k30k3g4jkhhvq28vbqa0rmkyxk7";
rev = "bf0b97d48c4b17e5dc96ddfa0eabd4c2c9a74b21";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can refer to tags as well, which is preferable if there is one associated with the release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍. Updated the commit.

@rszibele rszibele changed the title curlcpp: 20160901 -> 20170320 curlcpp: 20160901 -> 1.0 Apr 22, 2017
@joachifm joachifm merged commit 5f9096a into NixOS:master Apr 22, 2017
@joachifm
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

@rvl rvl rvl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rszibele @mention-bot @rvl @joachifm