Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-chromiumos: remove 3.14 #25146

Merged
merged 1 commit into from Apr 25, 2017
Merged

linux-chromiumos: remove 3.14 #25146

merged 1 commit into from Apr 25, 2017

Conversation

zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Apr 23, 2017

3.14 is no longer supported upstream by kernel.org and thus no longer
receives security patches. The git commit mentioned in this .nix isn't
even available in the linked repository --
https://chromium.googlesource.com/chromiumos/third_party/kernel -- so I
think this .nix might be dead anyway. Finally, it specifies 3.14.0,
which is so ridiculously old (the latest was 3.14.79) that nobody
develops for it.

Fixes: #25145
Supports: #25127

@mention-bot
Copy link

@zx2c4, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zohl, @joachifm and @dezgeg to be potential reviewers.

@grahamc
Copy link
Member

grahamc commented Apr 23, 2017

Nice to see your contribution! I'm happy to merge this, and agree with your assessment. @zohl is there a realistic alternative we should pursue? Do you still use these kernels?

@joachifm
Copy link
Contributor

Previously #18726

@Mic92
Copy link
Member

Mic92 commented Apr 23, 2017

Seems to be still actively maintained (last commit yesterday). https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14

Maybe we can increase the patch level version, if we can identify a compatibility with the corresponding lts release.

@zohl
Copy link
Contributor

zohl commented Apr 23, 2017

@grahamc, yes, I still use this kernel, but I don't mind of removing it.

There are at least two alternatives to v3.14 kernel:

  • chromiumos kernel v3.18 [1]
  • linux-samus kernel [2]

The first one builds and runs fine, but there is no sound support at all.
The second one requires some adjustments as when I tried it, not everything worked as smoothly as in chromuim's v3.14. I think this is the only proper alternative.

Fortunately, soon I'll have enough free time to look closely at it and finally get rid of v3.14 on my machine. This PR is a good call to action :)

FWIW, I still use very old version of nixpkgs as there were some changes in hardware detection at stage 1. And since I load the system from an external hard drive, it becomes unusable for me. (Loading from the internal drive should be fine.) That is another reason against v3.14 kernel.

[1] https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.18
[2] https://github.com/raphael/linux-samus

3.14 is no longer supported upstream by kernel.org and thus no longer
receives security patches. The git commit mentioned in this .nix isn't
even available in the linked repository --
https://chromium.googlesource.com/chromiumos/third_party/kernel -- so I
think this .nix might be dead anyway. Finally, it specifies 3.14.0,
which is so ridiculously old (the latest was 3.14.79) that nobody
develops for it.

Fixes: #25145
Supports: #25127
@zx2c4
Copy link
Contributor Author

zx2c4 commented Apr 23, 2017

@Mic92 wrote:

Seems to be still actively maintained (last commit yesterday).
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14

It's not maintained by kernel.org anymore. However, if you'd alternatively prefer to switch the .nix here to a more recent commit from the chromeos people, and then make sure to track their git repo carefully, that'd be a satisfactory solution to me. But IMHO it's easier and probably better to just get rid of ancient kernels.

Maybe we can increase the patch level version, if we can identify a compatibility with the corresponding lts release.

If you go this route, be very very certain you do this perfectly, since a lot of #ifdef hackery relies on you getting it perfect. O_o

@Mic92
Copy link
Member

Mic92 commented Apr 23, 2017

linux-samus sounds like the better option. Also it should support sound out-of-the-box.

@zx2c4
Copy link
Contributor Author

zx2c4 commented Apr 23, 2017

Great, I think we're in agreement then. Let's go ahead and merge this, and then after you can merge #25127?

@Mic92 Mic92 merged commit bd47d04 into NixOS:master Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants