Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hunspell: 1.3.3 -> 1.6.1 #25136

Merged
merged 1 commit into from Apr 23, 2017
Merged

hunspell: 1.3.3 -> 1.6.1 #25136

merged 1 commit into from Apr 23, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Apr 23, 2017 •
edited

Motivation for this change

Firefox 53 requires newer Hunspell.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I could not test qtwebkit-plugins because qutebrowser is broken with both Hunspell 1.3 and 1.6: This application failed to start because it could not find or load the Qt platform plugin "xcb" in "".
Nor i cloud not test mudlet because I could not build it with Hunspell 1.3.

@mention-bot
Copy link

@taku0, thanks for your PR! By analyzing the history of the files in this pull request, we identified @urkud, @dezgeg and @Fuuzetsu to be potential reviewers.

@taku0 taku0 mentioned this pull request Apr 23, 2017
Merged
7 tasks
@taku0
Copy link
Contributor Author

taku0 commented Apr 23, 2017

Other nox-review results:

Package Error Message
ekiga You need the libresolv library to compile Ekiga
gitg (libgit2-glib) implicit declaration of function 'git_blob_create_fromchunks' [-Werror=implicit-function-declaration]
libsForQt56.kirigami_2 Could not find a configuration file for package "Qt5" that is compatible with requested version "5.7.0".
python27Packages.willie ConfigParser.py:340: NoOptionError

@7c6f434c 7c6f434c merged commit 8611d92 into NixOS:master Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @mention-bot @7c6f434c