ocamlPackages.utop: fix environment variables #25122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the shared objects setup hook to prepare CAML_LD_LIBRARY_PATH.
This adds the shared objects setup hook to prepare CAML_LD_LIBRARY_PATH.
|
@pmahoney, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FlorentBecker, @vbgl and @maggesi to be potential reviewers. |
|
This reintroduces #24496. |
In the wrapper scripts, both OCAMLPATH and CAML_LD_LIBRARY_PATH where
being created with a trailing literal $OCAMLPATH, rather than the
expanded version. Thus if, for example, ocamlPackages.core was present
in OCAMLPATH prior to running utop, the wrapper script would set the
variable to $utop_dependencies:'$OCAMLPATH', and when using utop to
open Core.Std, the following error was reported:
findlib: [WARNING] cannot read directory $OCAMLPATH: No such file
or directory
This patch fixes the quoting issue, and further refactors the build to
use standard wrapProgram helper, and uses an "inner derivation" to
re-use the setupHook machinery of buildOCaml and findlib instead of
manually specifying the OCAMLPATH required for utop along with
transitive dependencies.
|
@vbgl ping. utop is completely broken for me without this patch (at least when using Core). |
|
Merged, hopefully correctly… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Given a
nix-shellwithocamlPackages.coreonOCAMLPATH,utopis unable to load Core.Std. The error was:This is because the wrapper script inserts a literal
$OCAMLPATHinto the$OCAMLPATHenvironment variable, rather than expanding the existing value.This has not received extensive testing, but does solve my immediate problem. I'd like to get feedback from @vbgl or @FlorentBecker. Would also like to test on Linux at least, possibly NixOS.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)