ffmpeg(and -full) updates, use SDL2 instead of SDL for versions >3.2 #25132
Conversation
remove legacy x11grab and memalign configure option, both removed as of 3.3
addresses issue NixOS#24658 special thanks to codyopel who suggested this solution!
|
@MP2E, thanks for your PR! By analyzing the history of the files in this pull request, we identified @codyopel, @wkennington and @acowley to be potential reviewers. |
|
We should delete any ffmpeg that we can, meaning other packages can upgrade to newer ffmpegs. |
|
The announcement mentions nothing about backwards compatibility. I see a couple of fields removed from |
|
I added another commit removing ffmpeg 3.2 and 3.1 if we would like to go forward with removing them, however, this commit can also be safely ignored if instead it would be better to keep them. Either way is fine by me. ffmpeg 3.1 is not needed anymore because nothing in the tree depends on it, so we could also go the middle ground route and only remove ffmpeg_3_1. |
effectively updates them to depend on ffmpeg_3_3
|
Travis found some programs that were depending on ffmpeg_3_2, changed those to use ffmpeg |
|
After some testing, I went ahead and pushed! Would be happy to follow up with any issues if they arise. |
Motivation for this change
ffmpeg released version 3.3 recently so this updates both ffmpeg and ffmpeg-full, this PR also addresses issue #24658
ffmpeg-full had 2 options removed, '--enable-memalign-hack' and '--enable-x11grab'.
x11grab was deprecated and removed in favor of libxcb, the memalign hacks configure option was fully removed from ffmpeg
as a side note, should older ffmpeg 3.x releases get removed?
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)