Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all-the-icons: init at 2.5.0 #25112

Closed
wants to merge 1 commit into from
Closed

all-the-icons: init at 2.5.0 #25112

wants to merge 1 commit into from

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 22, 2017

Motivation for this change

Resource Fonts included in the package all-the-icons.el (a utility package to collect various Icon Fonts and propertize them within Emacs).

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

It looks like this is identical to #25119?

@rlupton20
Copy link
Contributor

Yeah, I'd opened my pull request and then spotted this. I'd checked on Friday!

Sorry @romildo, my pull request was almost exactly the same!

@romildo romildo closed this Apr 24, 2017
@romildo romildo deleted the new.all-the-icons branch December 5, 2017 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants