gdal: Add optional SQLite & Spatialite support #25114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hodapp87, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bzizou, @MarcWeber and @michelk to be potential reviewers. |
|
Is there something speaking against enabling them by default? I would make it easier for people to use the feature or is this something most people don't need? |
|
I don't really know. I think it was mostly a niche thing that I happened to need. |
|
There's a whole bunch of other flags that are set. Why make these an explicit option? If these two additional flags don't have a considerable impact on the closure size, then its fine to just add them. Users can always override the derivation. |
|
Are you suggesting getting rid of |
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
gdal supports reading and writing from SQLite with and without Spatialite, but this requires that the libraries be present. This commit adds optional support for those libraries, leaving them disabled by default.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)