Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd: 3.0.6 -> 3.1.6 #25142

Merged
merged 1 commit into from Apr 23, 2017
Merged

etcd: 3.0.6 -> 3.1.6 #25142

merged 1 commit into from Apr 23, 2017

Conversation

kevincox
Copy link
Contributor

@kevincox kevincox commented Apr 23, 2017

Upgrade etcd.

  • Switches from their old dependency version system to their vendored packages.
  • Fixes SSL support.
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Upgrade etcd.

- Switches from their old dependency version system to their vendored packages.
- Fixes SSL support.
@mention-bot
Copy link

@kevincox, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kamilchm and @offlinehacker to be potential reviewers.

@grahamc
Copy link
Member

grahamc commented Apr 23, 2017

Have you run the tests in nixos/tests/etcd-cluster.nix and nixos/tests/etcd.nix?

@kevincox
Copy link
Contributor Author

kevincox commented Apr 23, 2017 via email

@Mic92 Mic92 merged commit e57a4f3 into NixOS:master Apr 23, 2017
@kevincox kevincox deleted the etcd-3.1.6 branch April 29, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants