Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs: 25.1 -> 25.2 #25124

Merged
merged 2 commits into from Apr 27, 2017
Merged

emacs: 25.1 -> 25.2 #25124

merged 2 commits into from Apr 27, 2017

Conversation

sigma
Copy link
Contributor

@sigma sigma commented Apr 22, 2017

Motivation for this change

package new Emacs release.
Also update macport to corresponding patchset, and bring some more homogeneity between the two builds.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@sigma, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jwiegley, @the-kenny and @dudebout to be potential reviewers.

Copy link
Contributor

@mdorman mdorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this down and built it and it appears to work fine.

@fpletz
Copy link
Member

fpletz commented Apr 27, 2017

Also tested successfully with spacemacs config.

@fpletz fpletz merged commit 7a66134 into NixOS:master Apr 27, 2017
svend pushed a commit to svend/nixpkgs that referenced this pull request Apr 28, 2017
@sigma sigma deleted the pr/emacs-25.2 branch April 30, 2017 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants