python-pytest-xdist: disable tests on darwin #25725
Closed
+30
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LnL7
added
6.topic: darwin
FRidh
reviewed
May 12, 2017
|
|
||
| # Test fails for python3: | ||
| # dsession (unittest.loader._FailedTest) ImportError: cannot import name 'collect_one_node' | ||
| doCheck = !stdenv.isDarwin; |
There was a problem hiding this comment.
I think what is needed is a
checkPhase = ''
py.test
'';
but I'm not sure
There was a problem hiding this comment.
indeed, I did have to disable some of the tests
Mic92
reviewed
May 13, 2017
| ''; | ||
|
|
||
| checkPhase = '' | ||
| py.test |
There was a problem hiding this comment.
In pytest runner you can disable tests like this:
py.test -k "not test_foo and not test_bar"
There was a problem hiding this comment.
It's about 10 test cases in total, I didn't want to disable them all separately.
|
Pushed e5a4da2 |
|
Hmm, I didn't check the build before pushing, but I'm getting failing tests on NixOS as well. |
|
Strange, pretty sure I tested it on both platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Not sure why the failure only happens on darwin (python3). http://hydra.nixos.org/build/52755528
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)