Resource manager fixes #2623
Merged
Resource manager fixes #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
force-pushed
the
Resource_manager_fixes
branch
from
e64bfa5
to
ff1eff2
Compare
- adding missing code - adding test - thread_pool_executors now report real number of assigned cores
- flyby changes necessary to make HPXrx work # Conflicts: # hpx/runtime/threads/detail/scheduling_loop.hpp
# Conflicts: # hpx/runtime/threads/detail/scheduling_loop.hpp
hkaiser
force-pushed
the
Resource_manager_fixes
branch
from
ff1eff2
to
f3bf350
Compare
hkaiser
force-pushed
the
Resource_manager_fixes
branch
from
f3bf350
to
6c3348a
Compare
sithhell
requested changes
May 18, 2017
| { | ||
| for (int i = 0; i != num_tasks; ++i) | ||
| { | ||
| traits::apply_execute(exec, |
There was a problem hiding this comment.
could this use the new executor interface instead?
| { | ||
| for (int i = 0; i != num_tasks; ++i) | ||
| { | ||
| traits::apply_execute(exec, |
There was a problem hiding this comment.
could this use the new executor interface instead?
|
@sithhell Your comments have been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of fixes I had lying around for a while in my local copy of the repository.
This improves the behavior of the resource-manager in cases where the user requests more resources than available.