Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchange RadicalSiteRrDeltaReaction and RadicalSiteRrGammaReaction #315

Merged
merged 1 commit into from May 6, 2017
Merged

Exchange RadicalSiteRrDeltaReaction and RadicalSiteRrGammaReaction #315

merged 1 commit into from May 6, 2017

Conversation

kazuyaujihara
Copy link
Contributor

I believe RadicalSiteRrDeltaReaction and RadicalSiteRrGammaReaction must be exchanged.
It means magic numbers 3 and 4 in RadicalSiteRrDeltaReaction are correctly 4 and 5, and 4 and 5 in RadicalSiteRrGammaReaction are correctly 3 and 4.

@johnmay johnmay mentioned this pull request May 6, 2017
Merged
@johnmay
Copy link
Member

johnmay commented May 6, 2017

Yep looks correct, #319 makes this more obvious from a high level:

Currently:

[CH](CCC)CCC>>[CH2]CC(C)CCC |^1:0,7| RadicalSiteRrAlphaReaction
[CH](CC)CCCC>>[CH2]CCC(C)CC |^1:0,7| RadicalSiteRrBetaReaction
[CH2]CCCCCC>>[CH2]CCCCCC |^1:0,7| RadicalSiteRrGammaReaction
[CH](C)CCCCC>>[CH2]CCCC(C)C |^1:0,7| RadicalSiteRrDeltaReaction

After:

[CH](CCC)CCC>>[CH2]CC(C)CCC |^1:0,7| RadicalSiteRrAlphaReaction
[CH](CC)CCCC>>[CH2]CCC(C)CC |^1:0,7| RadicalSiteRrBetaReaction
[CH](C)CCCCC>>[CH2]CCCC(C)C |^1:0,7| RadicalSiteRrGammaReaction
[CH2]CCCCCC>>[CH2]CCCCCC |^1:0,7| RadicalSiteRrDeltaReaction

@johnmay johnmay merged commit 5f1f16e into cdk:master May 6, 2017
@kazuyaujihara kazuyaujihara deleted the patch/reaction branch May 6, 2017 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kazuyaujihara @johnmay