Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.rfc3986: 0.2.2 -> 0.4.1 #25751

Merged
merged 1 commit into from
May 20, 2017
Merged

pythonPackages.rfc3986: 0.2.2 -> 0.4.1 #25751

merged 1 commit into from
May 20, 2017
+25 −17

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented May 12, 2017

Motivation for this change

Dependency of next Keystone release

Things done
  • [] Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

nox failed due to pythonPackages.cinderclient (which is tagged as broken)

Sorry, something went wrong.

@mention-bot
Copy link

@nlewo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@nlewo nlewo mentioned this pull request May 12, 2017
Closed
@nlewo
Copy link
Member Author

nlewo commented May 12, 2017

Related to #25752

@pSub pSub added 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version and removed 8.has: package (new) This PR adds a new package labels May 14, 2017
@nlewo
Copy link
Member Author

nlewo commented May 15, 2017

A check failed because log file was too big. Others are green.

@Mic92 Mic92 merged commit c1a5754 into NixOS:master May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nlewo @mention-bot @pSub @Mic92