Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gimp: 2.8.20 -> 2.8.22 #25767

Merged
merged 1 commit into from
Jun 3, 2017
Merged

gimp: 2.8.20 -> 2.8.22 #25767

merged 1 commit into from
Jun 3, 2017

Conversation

armijnhemel
Copy link
Contributor

Motivation for this change

new version

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@armijnhemel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @paperdigits, @cillianderoiste and @bluescreen303 to be potential reviewers.

@paperdigits
Copy link
Contributor

The focusblur plugin has failed to build on Travis. We should really review the plugins, as the GAP plugin was failing for me as well.

@armijnhemel
Copy link
Contributor Author

I don't think that the GAP plugin was actually ported to 2.8, so perhaps it is better to retire it?

@armijnhemel
Copy link
Contributor Author

I built the plugins on my Fedora 25 and they are building just fine.

@grahamc
Copy link
Member

grahamc commented Jun 3, 2017

LGTM thank you!

@grahamc grahamc merged commit b520c30 into NixOS:master Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants