Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fwup: init at 0.14.2 #25760

Merged
merged 1 commit into from
May 19, 2017
Merged

fwup: init at 0.14.2 #25760

merged 1 commit into from
May 19, 2017

Conversation

georgewhewell
Copy link
Contributor

Motivation for this change

adds fwup package

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed May 13, 2017
View reviewed changes
pkgs/tools/misc/fwup/default.nix Outdated
NIX_LDFLAGS = lib.optional stdenv.isDarwin "-F/System/Library/Frameworks";

# stop test runner from switching to BSD utils
preCheck = lib.optional stdenv.isDarwin "sed -i tests/common.sh -e 24,37d";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be better a patch. Otherwise it might silently break with an update.

Mic92
Mic92 reviewed May 13, 2017
View reviewed changes
pkgs/tools/misc/fwup/default.nix Outdated
description = "Configurable embedded Linux firmware update creator and runner";
homepage = https://github.com/fhunleth/fwup;
license = licenses.asl20;
platforms = platforms.all;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to maintain this package?

@georgewhewell
Copy link
Contributor Author

@Mic92 Thanks, added maintainer and patch.

@Mic92
Copy link
Member

Mic92 commented May 14, 2017 •
edited

For some strange reasons some tests fail on my machine, while functional on travis:

https://gist.github.com/Mic92/cda72ea4f028ff33e440c22dc2df15de

@Mic92 Mic92 closed this May 14, 2017
@Mic92 Mic92 reopened this May 14, 2017
@georgewhewell
Copy link
Contributor Author

@Mic92 Hmm, strange. Are you using NixOS? Which filesystem? I will try to replicate.

@Mic92
Copy link
Member

Mic92 commented May 19, 2017

Oh, could be that it does fail on zfs, I will checkout on ext4.

@Mic92 Mic92 merged commit 28f8e5b into NixOS:master May 19, 2017
@Mic92
Copy link
Member

Mic92 commented May 19, 2017

ok, ext4 works fine.

@georgewhewell
Copy link
Contributor Author

@Mic92 thanks, I replicated this on ZFS and reported upstream

@georgewhewell georgewhewell deleted the fwup branch May 19, 2017 10:37
@matthewbauer
Copy link
Member

This seems to be failing:

https://hydra.nixos.org/job/nixpkgs/trunk/fwup.x86_64-linux

@Mic92
Copy link
Member

Mic92 commented May 20, 2017

Looks also filesystem related.


FAIL: 105_require_path_on_device
================================

1c1
< fwup: correct
---
> fwup: catchall

Test failed!

Leaving test work files in '/build/fwup-v0.14.2-src/tests/work-105_require_path_on_device.test'
FAIL 105_require_path_on_device.test (exit status: 1)

@georgewhewell
Copy link
Contributor Author

@matthewbauer @Mic92 Thanks, have reported upstream. The ZFS issues have been resolved, I will open PR to update the derivation once a new version with fixes has been released.

@georgewhewell georgewhewell mentioned this pull request May 21, 2017
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@georgewhewell @Mic92 @matthewbauer @pSub