WIP: atril: init at 1.19.0 #25765
WIP: atril: init at 1.19.0 #25765
Conversation
|
@armijnhemel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @romildo and @clemensmanert to be potential reviewers. |
|
On unstable NixOS it compiles and displays PDF ok. Maybe you want to add yourself as maintainer. |
pkgs/desktops/mate/atril/default.nix
Outdated
| homepage = "http://mate-desktop.org"; | ||
| license = with stdenv.lib.licenses; [ gpl2 ]; | ||
| platforms = stdenv.lib.platforms.unix; | ||
| }; |
There was a problem hiding this comment.
In license you used with, but in platforms you did not. It would be more consistent with it is used in both or in none of them.
There was a problem hiding this comment.
I just copied the expression for caja.
There was a problem hiding this comment.
with does not make much sense in that case. Please just use license = stdenv.lib.licenses.gpl2;.
pSub
added
2.status: work-in-progress
|
Due to time concerns I wiould rather have someone else as maintainer :) |
pkgs/desktops/mate/atril/default.nix
Outdated
| configureFlags = [ "--disable-caja" ]; | ||
|
|
||
| meta = { | ||
| description = "Atril is a simple multi-page document viewer for the MATE desktop"; |
There was a problem hiding this comment.
description should not contain the package name.
|
Alrighty, changed the description. Anything else? :-) |
Motivation for this change
add atril from MATE desktop. Compiles fine on Fedora 25, but for some reason cannot display PDF documents yet.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)