i3lock-pixeled: init at 1.1.0 #25761
Conversation
|
I rebased onto the fixed master, so |
| { stdenv, pkgs, fetchurl }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "i3lock-pixeled-pkg-${version}"; |
| version = "1.1.0"; | ||
|
|
||
| src = fetchurl { | ||
| url = "https://github.com/Ma27/i3lock-pixeled/archive/1.1.0.tar.gz"; |
There was a problem hiding this comment.
You could prefer:
url = "https://github.com/Ma27/i3lock-pixeled/archive/${version}.tar.gz";for easier maintenance.
|
good catches, thanks @lsix |
| sha256 = "046qbx4qvcc66h53h4mm9pyjj9gjc6dzy38a0f0jc5a84xbivh7k"; | ||
| }; | ||
|
|
||
| buildInputs = with pkgs; [ i3lock imagemagick scrot playerctl ]; |
There was a problem hiding this comment.
I think that buildInputs should be renamed propagatedBuildInputs since all those programs are required at run-time and not present otherwise.
|
The script cannot find |
|
I added a patchPhase (inspired by Furthermroe I squashed everything into a single commit to avoid a bloated history. |
|
anything else missing?? |
|
I rebased onto the current master and the build seems fine now... |
| --replace i3lock "${pkgs.i3lock}/bin/i3lock" \ | ||
| --replace convert "${pkgs.imagemagick}/bin/convert" \ | ||
| --replace scrot "${pkgs.scrot}/bin/scrot" \ | ||
| --replace playerctl "${pkgs.playerctl}/bin/playerctl#" |
There was a problem hiding this comment.
I think that this breaks the executable as # is interpreted as comment in a shell file, right?
Motivation for this change
Simple derivation for my
i3lockhelper.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)