azure-image: remove qemu-220 #25661
azure-image: remove qemu-220 #25661
Conversation
We don't need this according to NixOS#16437
|
@puffnfresh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @rbvermaa and @Phreedom to be potential reviewers. |
|
@fadenb Do you have time to test this? 🙂 |
|
I believe it is missing the -o force_size option. See #25197 (comment) and the other comments. I can test this later today. |
There was a problem hiding this comment.
I finally found the time to test this PR. As expected the produced image was not accepted by Azure:
The VHD for disk 'nixosVMelasticosdisk' with blob https://somename.blob.core.windows.net/graylog-images/nixosVM-elastic-0-osdisk.vhd has an unsupported virtual size of 30720.375 MB. The size must be a whole number in (MBs).
|
(just stumbled on this PR again) |
|
Per this comment, https://bugs.launchpad.net/qemu/+bug/1490611/comments/39, you need to add I'm working on some other Azure changes, including this. I'll send some PRs if it all works out. Apologies for not being more detailed in the Issue that triggered this... edit: Also, for apparently not reading the thread very well. @fadenb Did you happen to try with both force_size and fixed? That's what the qemu-img maintainers tested as working. |
|
@colemickens: Sorry, I can not remember exactly what I did back then. I suspect I tested that combination as I did quite a few tests but I am not sure. |
|
@fadenb It's alright. I've been creating and using new images myself using the mainline |
|
we merged #41881 instead. |
We don't need this according to #16437
Motivation for this change
Fixing old issues.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)