Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Store nesting to fix import-from-derivation within filterSource #1358

Merged
merged 1 commit into from Apr 26, 2017

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Apr 26, 2017

No description provided.

@edolstra
Copy link
Member

Isn't it easier to add the inc/decCapacity call to RemoteStore::addToStore()? That would remove the need for the Nest class and changes to the Store API.

@shlevy
Copy link
Member Author

shlevy commented Apr 26, 2017

If we're sure we're not going to need to do this elsewhere, sure.

@shlevy
Copy link
Member Author

shlevy commented Apr 26, 2017

@edolstra updated

@edolstra edolstra merged commit 39b08f4 into NixOS:master Apr 26, 2017
@copumpkin
Copy link
Member

@shlevy out of curiosity, how else might it be used? This feels vaguely in the direction of the stratification/recursive Nix stuff, so if we can enable that sort of thing little by little, it feels nice.

@shlevy
Copy link
Member Author

shlevy commented Apr 26, 2017

Nah, it wouldn't really be useful toward that case. It's really just about working around protocols that don't naturally nest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants