imagej: init at 150 #25249
imagej: init at 150 #25249
Conversation
| ''; | ||
| license = lib.licenses.publicDomain; | ||
| platforms = with stdenv.lib.platforms; linux; | ||
| maintainers = [ "Yuri Aisaka <yuri.aisaka+nix@gmail.com>" ]; |
There was a problem hiding this comment.
Please add an entry to lib/maintainers.nix
| @@ -0,0 +1,40 @@ | |||
| { stdenv, lib, fetchurl, jre, unzip, makeWrapper }: | |||
There was a problem hiding this comment.
lib is also available via stdenv.lib.
| @@ -14197,6 +14197,8 @@ with pkgs; | |||
| inherit (perlPackages.override { pkgs = pkgs // { imagemagick = imagemagickBig;}; }) PerlMagick; | |||
| }; | |||
|
|
|||
| imagej = callPackage ../applications/graphics/imagej { }; | |||
There was a problem hiding this comment.
Note that imagej here will refer to a set unlike most other toplevel bindings. The evaluator also will normally not recurse into sets, unless instructed to with recurseIntoAttrs. What is the motivation for returning a set to begin with?
There was a problem hiding this comment.
Even worse, the actual package will not have meta attached to it.
There was a problem hiding this comment.
the following is usually preferred:
inherit (callPackage ../applications/graphics/imagej { }) imagej150;
imagej = imagej150;
Also I find using sets with a single element premature optimization.
There was a problem hiding this comment.
What is the motivation for returning a set to begin with?
The reason I've used a set stems from my ignorance on a fundamental level; and on a superficial level, it is because jvm based nix packages I've consulted were popular giants like eclipse.
|
@joachifm @7c6f434c @Mic92 I will try to update the pull request to reflect the advises above:
Also I shall take this opportunity to
|
|
Thanks! |
Motivation for this change
add ImageJ (a Java based image processing/analysis software).
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)meta.maintainersis set (by adding an email address todefault.nix; no entries were added tolib/maintainers.nix)Possible improvements
ImageJ by using JDK version 48 ("JDK 1.4") or later.
using the JDK version 49 ("JDK 5"), and thus should work on every platform
where a JRE of version 49 or later is available.
Comments