Update pythonPackages.channels and dependencies #25243
Conversation
lsix
force-pushed
the
update_channels
branch
2 times, most recently
from
378d016
to
83b976c
Compare
|
@lsix looks good to me. Could you rebase this? |
|
@FRidh rebased and conflicts merged ! |
| buildInputs = [ unittest2 mock pytest trollius pytest-asyncio ]; | ||
| propagatedBuildInputs = [ six twisted txaio ]; | ||
|
|
||
| disabled = !isPy3k; |
There was a problem hiding this comment.
Why are you disallowing python2.7 here? The upstream package claims Python2.7 support. This breaks any python package that depends on 2.7 and autobahn.
There was a problem hiding this comment.
You are right, this is missplaced. This should be in pytest-asyncio which is python3 only. But the problem will remain, tests cant pass for autobahn for python2. I have opened a PR to fix it and build autobahn for python2 while skiping tests (#25460).
There was a problem hiding this comment.
I'm not that familiar with asyncio, but the upstream package uses trollius, which claims to be a backport of asyncio. Wouldn't that work here?
There was a problem hiding this comment.
Yes, but tests will run pytest-asyncio, which contains code with python2 incompatible syntax (and incompatible language anyway). This is different from runtime dependencies needed to run autobahn. It might well work with python2 install but we cannot check it with the provided test suite.
I am updating to the recent release of autobahn and fix runtime dependencies.
Motivation for this change
Sorry for the amount of changes in one PR, updating one component triggered many required related updates.
Some package have invalid syntax for python3 and caused
nox-reviewto failed. I have disabled them for python3, to get nox pass properly.cc @FRidh
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)