Node renderer fixes #510
Merged
Node renderer fixes #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.0 has better error logging (doesn't obscure uncaught exceptions). The install() line had to be moved because Raven.wrap now throws an exception if Raven isn't configured yet.
Use RegExp.prototype.test, which is supported in older versions of node.
mwiencek
force-pushed
the
node-fixes
branch
3 times, most recently
from
4f13891
to
01cac55
Compare
Even though killNext and receiveData are inside functions which are already wrapped, they're executed in different stack frames, so they also needs to be wrapped.
Object.values is unavailable in older versions of Node. Object.keys should be fine, but I've replaced it too for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't much effort to fix, so here it is. Tested with the help of adhawkins.
I updated node-raven to v2 because it was impossible to even see what the errors were without it (v1 hid uncaught exceptions).