Documentation for HTTP.rfc1123_date. #4418
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akzhan
force-pushed
the
doc-HTTP.rfc1123_date
branch
from
67a8255 to
4c3890e
Compare
|
@bew just note about akzhan@4c3890e#commitcomment-22167223: it's not true. A lot of documentation has same output without any Simply look for But I'll remove assignment due to its useless. Update forced. Thanks. |
Heavily inspired by http://ruby-doc.org/stdlib-2.0.0/libdoc/cgi/rdoc/CGI.html#method-c-rfc1123_date [ci skip]
akzhan
force-pushed
the
doc-HTTP.rfc1123_date
branch
from
4c3890e to
8bdce03
Compare
|
|
akzhan
referenced
this pull request
in akzhan/crystal
May 16, 2017
Heavily inspired by http://ruby-doc.org/stdlib-2.0.0/libdoc/cgi/rdoc/CGI.html#method-c-rfc1123_date [ci skip]
|
btw, thanks for filling gaps in documentation, much appreciated! 👍 |
|
@Sija Fixed. P.S.: I will commit code without force updates due to keep comments history. |
|
@akzhan no need to, they'll probably be squashed anyway. |
|
@Sija Keeping commit/comment history is useful for the duration of the PR, even if they will be squashed and not preserved when merged into master. |
RX14
approved these changes
May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily inspired by http://ruby-doc.org/stdlib-2.0.0/libdoc/cgi/rdoc/CGI.html#method-c-rfc1123_date