Distributed define_spmd_block #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sithhell
reviewed
May 16, 2017
hpx/lcos/spmd_block.hpp
Outdated
|
|
||
| int * dummy = nullptr; | ||
| hpx::util::invoke( | ||
| reinterpret_cast<const F&>(*dummy), |
There was a problem hiding this comment.
How should this work? invoke will certainly dereference a nullptr. This is UB.
There was a problem hiding this comment.
Lambda overload removed in 4657f0e
sithhell
reviewed
May 16, 2017
hpx/lcos/spmd_block.hpp
Outdated
| decltype( &helper_type::call ), &helper_type::call >::type; | ||
|
|
||
| // Initialize f at compile-time in case when f is a lambda function | ||
| hpx::lcos::detail::initialize_if_lambda(f); |
There was a problem hiding this comment.
This doesn't really work. It only might work if f has no state. This limits the usefulness of spmd_block tremenedously.The nullptr dereference and that you don't transfer the callable to the remote is just calling for trouble.
Naios
reviewed
May 16, 2017
hpx/parallel/spmd_block.hpp
Outdated
|
|
||
| // Asynchronous version | ||
| template <typename ExPolicy, typename F, typename ... Args, | ||
| typename = typename std::enable_if< | ||
| hpx::parallel::v1::is_async_execution_policy<ExPolicy>::value>::type | ||
| > | ||
| std::vector<hpx::future<void>> | ||
| inline std::vector<hpx::future<void>> |
There was a problem hiding this comment.
templated functions have inline linkage by default
atrantan
force-pushed
the
lcos_define_spmd_block
branch
5 times, most recently
from
f48b87e
to
062db7f
Compare
|
@sithhell Is the PR now good for U? |
sithhell
requested changes
May 26, 2017
hpx/lcos/spmd_block.hpp
Outdated
| { | ||
| using type = typename std::decay<Arg0>::type; | ||
| }; | ||
| } |
There was a problem hiding this comment.
This should be factored out and merged with the one defined in hpx/lcos/local/spmd_block.hpp
added 14 commits
May 29, 2017 11:02
atrantan
force-pushed
the
lcos_define_spmd_block
branch
2 times, most recently
from
77ecb48
to
0b2d5ae
Compare
atrantan
force-pushed
the
lcos_define_spmd_block
branch
from
0b2d5ae
to
7d6afc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch tries to implement a distributed version of
define_spmd_block().Here are the following changes:define_spmd_block()and localspmd_block()have been moved tohpx::lcos::localhpx::parallel::v2::spmd_blockis now defined as a type aliashpx::parallel::v2::define_spmd_block()is now wrapping a call tohpx::lcos::local::define_spmd_block()define_spmd_block()and globalspmd_block()(based onbroadcastandhpx::lcos::barrier) added and located inhpx::lcos