Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdevelop: Fix shell integration (issue 25559) #25691

Merged
merged 1 commit into from
May 13, 2017
Merged

kdevelop: Fix shell integration (issue 25559) #25691

merged 1 commit into from
May 13, 2017

Conversation

ambrop72
Copy link
Contributor

Motivation for this change

Fixes issue 25559.
Tested in release-17.03.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ambrop72 ambrop72 mentioned this pull request May 10, 2017
Merged
7 tasks
@Mic92 Mic92 closed this May 11, 2017
@ambrop72
Copy link
Contributor Author

@Mic92 , I made two pull requests, this one for master and #25692 one for release-17.03.

@Mic92 Mic92 reopened this May 11, 2017
@Mic92
Copy link
Member

Mic92 commented May 11, 2017

Ok, it is usually enough to make a pull request from master and the maintainers will back-port changes by cherry-picking.

@ttuegel ttuegel merged commit 0442676 into NixOS:master May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ambrop72 @Mic92 @ttuegel