pharo-vm: Add third-party libraries to LD_LIBRARY_PATH #25681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the third party libraries needed by the default Pharo environment to the LD_LIBRARY_PATH, by using makeWrapper.
|
@Balletie, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DamienCassou, @lukego and @globin to be potential reviewers. |
|
That looks good to me. I did something similar in the experimental #25058. |
|
Thank you for your review :) |
|
@Balletie Glad to review. Note: I marked myself as the maintainer for the Pharo packages, because I am depending on them, but I don't have commit on |
|
Sure, we can do that. If you want you can cherry-pick from my branch |
|
This has been merged. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The default Pharo image has code which uses the freetype and cairo libraries. When that code was executed it threw an error saying that it couldn't find these libraries. This PR fixes it by putting the libraries in
LD_LIBRARY_PATHusing a wrapper.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)