sgtpuzzles: fix broken gtk3 file dialog #25694
Merged
+17
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XDG_DATA_DIRS need to be set for file dialog to work
|
@olejorgenb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @7c6f434c and @pSub to be potential reviewers. |
Mic92
reviewed
May 11, 2017
pkgs/games/sgt-puzzles/default.nix
Outdated
| let | ||
| { stdenv, fetchurl | ||
| , gtk3, libX11 | ||
| , makeWrapper, pkgconfig, perl, autoreconfHook, wrapGAppsHook |
There was a problem hiding this comment.
wrapGAppsHook is usually the better, more complete fix here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Start any puzzle (eg.
loopy) and try to save. The program crash withThings done
Wrap all binaries with XDG_DATA_DIRS prefixed to $GSETTINGS_SCHEMAS_PATH.
Note: I see that's there's quite some variety in how this issue has been fixed.
(Some suggest)[https://github.com//issues/23474#issuecomment-287562402] using
wrapGAppsHook? (but that might increase the closure size for simple programs that only need file dialogs?)Seems less than ideal to have to wrap (almost) every gtk program, at least if it requires writing a fixUp shell code snippet.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/) * Lot's of bin files, tested a few.