Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ezdxf (Python package): init at 0.8.1 #25192

Merged
merged 3 commits into from Apr 26, 2017
Merged

ezdxf (Python package): init at 0.8.1 #25192

merged 3 commits into from Apr 26, 2017

Conversation

Hodapp87
Copy link
Contributor

Motivation for this change

The Python module ezdxf is unavailable.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Hodapp87, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@@ -6990,6 +6990,28 @@ in {
};
};

ezdxf = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this to pkgs/development/python-modules/ezdxf/default.nix.

Copy link
Contributor Author

@Hodapp87 Hodapp87 Apr 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a clear criterion for what belongs inline in python-packages.nix and what belongs in a separate file? I just looked and guessed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every new/updated modules is eventually moved to python-modules.

version = "0.8.1";
name = "ezdxf-${version}";

src = pkgs.fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchPypi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchPypi isn't working here because the URL is a .zip, not a .tar.gz.

homepage = https://github.com/mozman/ezdxf/;
license = licenses.mit;
platforms = platforms.unix;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and will you maintain this package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then please add yourself as maintainer as described here: https://github.com/Mic92/nixos-wiki/wiki/Get-Involved#becoming-a-nixpkgs-maintainer

@Mic92 Mic92 merged commit 120f017 into NixOS:master Apr 26, 2017
@Hodapp87 Hodapp87 deleted the ezdxf branch April 26, 2017 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants