-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ezdxf (Python package): init at 0.8.1 #25192
Conversation
pkgs/top-level/python-packages.nix
Outdated
@@ -6990,6 +6990,28 @@ in { | |||
}; | |||
}; | |||
|
|||
ezdxf = buildPythonPackage rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move this to pkgs/development/python-modules/ezdxf/default.nix
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a clear criterion for what belongs inline in python-packages.nix
and what belongs in a separate file? I just looked and guessed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every new/updated modules is eventually moved to python-modules.
pkgs/top-level/python-packages.nix
Outdated
version = "0.8.1"; | ||
name = "ezdxf-${version}"; | ||
|
||
src = pkgs.fetchurl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchPypi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchPypi
isn't working here because the URL is a .zip
, not a .tar.gz
.
pkgs/top-level/python-packages.nix
Outdated
homepage = https://github.com/mozman/ezdxf/; | ||
license = licenses.mit; | ||
platforms = platforms.unix; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and will you maintain this package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then please add yourself as maintainer as described here: https://github.com/Mic92/nixos-wiki/wiki/Get-Involved#becoming-a-nixpkgs-maintainer
Motivation for this change
The Python module ezdxf is unavailable.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)