Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid empty subarchives #2735

Merged
merged 2 commits into from
May 7, 2017
Merged

Avoid empty subarchives #2735

merged 2 commits into from
May 7, 2017

Conversation

felixfontein
Copy link
Contributor

Fixes #2734.

Some archive pages are no longer created (more precisely: empty pages on month and year level), so strictly speaking this is breaking backwards compatibility.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
crazy-max CrazyMax
@Kwpolska Kwpolska requested a review from ralsina April 24, 2017 16:08
Copy link
Member

@Kwpolska Kwpolska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d consider this “breaks backwards compatibility, but compatibility with something dumb isn’t worth it”. LGTM.

@felixfontein
Copy link
Contributor Author

I agree. Should we wait for @ralsina, or merge now?

@Kwpolska
Copy link
Member

Let’s wait.

@felixfontein
Copy link
Contributor Author

@ralsina: can you take a look at this PR?

@ralsina
Copy link
Member

ralsina commented May 7, 2017

LGTM

@ralsina ralsina merged commit ef84f85 into master May 7, 2017
@ralsina ralsina deleted the avoid-empty-subarchives branch May 7, 2017 19:22
@felixfontein
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants