Implement aria2 service for controlling a daemon via rpc. #25181
Conversation
|
@indiscipline, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ehmry, @edolstra and @joachifm to be potential reviewers. |
|
Ping @LnL7, @jgeerds, @rasendubi (previously merged aria2-related PRs). |
nixos/modules/misc/ids.nix
Outdated
| @@ -547,6 +548,7 @@ | |||
| #rpc = 271; # unused | |||
| #geoip = 272; # unused | |||
| fcron = 273; | |||
| aria2 = 274; | |||
| accessible to users in the "aria2" group. | ||
| ''; | ||
| }; | ||
| openPorts = mkOption { |
There was a problem hiding this comment.
Services should not open firewall ports. (The only exception is sshd.)
There was a problem hiding this comment.
Sorry, my bad. Copied from some other service and did't give enough thought.
| }; | ||
| extraArguments = mkOption { | ||
| type = types.string; | ||
| example = "--rpc-secret=12345 --enable-rpc --rpc-listen-all"; |
There was a problem hiding this comment.
rpc-secret already has an option and --enable-rpc is always added, so these should not go into extraArguments
|
|
||
| Targets are downloaded to ${downloadDir} by default and are | ||
| accessible to users in the "aria2" group. | ||
| ''; |
There was a problem hiding this comment.
The usual indentation pattern for multi-line strings is next:
{
description = ''
blah-blah
'';
# ^ only two spaces here
}| wantedBy = [ "multi-user.target" ]; | ||
| preStart = '' | ||
| mkdir -m 0770 -p "${homeDir}" | ||
| chown aria2:aria2 "${homeDir}" |
There was a problem hiding this comment.
Indentation seems to be broken in preStart.
| ExecReload = "${pkgs.coreutils}/bin/kill -HUP $MAINPID"; | ||
| User = "aria2"; | ||
| Group = "aria2"; | ||
| PermissionsStartOnly = true; |
|
Is there anything else to be fixed before merge? |
|
Thanks for the contribution! |
|
Thanks for the review, @rasendubi. All went pretty smooth for a first PR. I'll try better next time, though. |
Motivation for this change
Implement aria2 systemd service for controlling a daemon instance via rpc. There's already a nix package for aria2, but no service unit. Aria2 can be controlled by a few freely-available web-uis via rpc calls.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)