top-level: common subexpression elimination for cc-wrapper usage #25186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `ccWrapperFun` can be used in a few more places instead of duplicating its definition. - `ccWrapper` parameter on `wrapCC` is always substituted with `ccWrapperFun` so just get rid of that parameter.
Ericson2314
force-pushed
the
ccwrapper-cse
branch
from
94bdfde
to
bef5278
Compare
Ericson2314
changed the title
7 tasks
|
This is really trivial, and tests, passed, so I'm just going to merge myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ccWrapperFuncan be used in a few more places instead of duplicating its definition.ccWrapperparameter onwrapCCis always substituted withccWrapperFunso just get rid of that parameter.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)