Gdm on nvidia #25621
Closed
Gdm on nvidia #25621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default tty1 is causing problems with getty@tty1.service and some other functions of NixOS.
…it for nvidia drivers.
|
@deedrah, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @lethalman and @aszlig to be potential reviewers. |
zimbatm
approved these changes
May 8, 2017
Mic92
reviewed
May 9, 2017
|
|
||
| # Create /dev/nvidia-uvm when the nvidia-uvm module is loaded. | ||
| services.udev.extraRules = | ||
| '' | ||
| KERNEL=="nvidia", RUN+="${pkgs.stdenv.shell} -c 'mknod -m 666 /dev/nvidiactl c $(grep nvidia-frontend /proc/devices | cut -d \ -f 1) 255'" |
There was a problem hiding this comment.
$(awk '/nvidia-frontend/ { print $1 }' /proc/devices) is slightly shorter.
There was a problem hiding this comment.
I wanted to stay consistent with the already present rule for nvidia-uvm. And awk is not in the path of udev service that will execute this.
|
Superseeded by #29697 with commits from this PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This PR should fix #24172 and possibly problems caused by #22470 together with other small tweaks for GDM.
I can only test it on system with a single NVIDIA card so feedback from different setups is welcome.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)