coyim: init at 0.3.7_1 #25093
Merged
coyim: init at 0.3.7_1 #25093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Apr 23, 2017
| sha256 = "1sna1n9dz1crws6cb1yjhy2kznbngjlbiw2diycshvbfigf7y7xl"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig glib cairo gdk_pixbuf gnome3.gtk ]; |
There was a problem hiding this comment.
wrapGAppsHook in buildInputs is almost always beneficial for gtk apps.
There was a problem hiding this comment.
Then adding hicolor_icon_theme to buildInputs should also just works.
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sadly I wasn't able to get the hicolor-icon-theme working. Besides that everything seems to be working fine
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)