Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kdeapps 17.04 #25094

Merged
merged 2 commits into from Apr 25, 2017
Merged

Kdeapps 17.04 #25094

merged 2 commits into from Apr 25, 2017

Conversation

vandenoever
Copy link
Contributor

Motivation for this change

Newer version with bugfixes for various applications.

https://www.kde.org/announcements/announce-applications-17.04.0.php

I tested not all packages. Packages I tested:

kate, kcalc, okular, spectacle, marble, konsole, kcachegrind, kig, okteta, kdenlive, dolphin, ark, konversation, khelpcenter, kdf, kompare

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of many binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@vandenoever, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel, @FRidh and @the-kenny to be potential reviewers.

@FRidh
Copy link
Member

FRidh commented Apr 21, 2017

...and I had just begun updating the package set. I'll test this as well.

@FRidh
Copy link
Member

FRidh commented Apr 21, 2017

I don't think this will go in 17.03. Instead, it should go in staging. Best to rebase on current nixpkgs-unstable.

@ttuegel
Copy link
Member

ttuegel commented Apr 21, 2017

Instead, it should go in staging

It should go into master.

@vandenoever vandenoever changed the base branch from release-17.03 to master April 21, 2017 18:51
@vandenoever
Copy link
Contributor Author

vandenoever commented Apr 21, 2017 •
edited

Starting to compile now.

@vandenoever
Copy link
Contributor Author

It compiles but applications fail to start on my system:

dolphin(6995)/default unknown: This application failed to start because it could not find or load the Qt platform plugin "xcb"
in "".

Available platform plugins are: wayland-org.kde.kwin.qpa, minimal, offscreen, xcb, vnc.

Reinstalling the application may fix this problem.
Aborted

The versions on the 17.03 branch did work fine.

@vandenoever
Copy link
Contributor Author

I've to note that my NixOS is still 16.09 because I need kmail which is not yet present in 17.03.

@ttuegel
Copy link
Member

ttuegel commented Apr 22, 2017

I've to note that my NixOS is still 16.09 because I need kmail which is not yet present in 17.03.

You cannot run newer Qt applications on an older NixOS.

@FRidh
Copy link
Member

FRidh commented Apr 22, 2017 via email

@vandenoever
Copy link
Contributor Author

You cannot run newer Qt applications on an older NixOS.
Why not? It's just a library like any other.

@ttuegel
Copy link
Member

ttuegel commented Apr 22, 2017

Why not? It's just a library like any other.

The master branch is using Qt 5.8, but your system has only Qt 5.6. When you run the Qt 5.8-based application, it will search your system for QPA platform plugins to provide desktop integration. When it finds the Qt 5.6-based QPA plugins, it will load them and then crash, as is well documented (#17448 #15498 and several others I can't recall).

@vandenoever
Copy link
Contributor Author

Ok, well, I'll need to backport the patch to 17.03 for my purposes then. For master the patch seems fine.

ttuegel
ttuegel reviewed Apr 24, 2017
View reviewed changes
pkgs/applications/kde/marble.nix Outdated
propagatedBuildInputs = [
qtscript qtsvg qtquickcontrols
qtdoc qtscript qtsvg qtquickcontrols qtwebkit shared_mime_info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think qtdoc is usually only needed during the build and not at runtime. If that's true here, could you move this to nativeBuildInputs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out it's not even required for building. I've removed it.

@ttuegel ttuegel merged commit de260d8 into NixOS:master Apr 25, 2017
@vandenoever vandenoever deleted the kdeapps-17.04 branch April 25, 2017 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel left review comments

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vandenoever @mention-bot @FRidh @ttuegel